close #292

lgatto · Dec 19, 2017 · cc4245e · cc4245e
1 parent 52352ce
commit cc4245e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/NEWS b/NEWS
@@ -1,7 +1,9 @@
 Changes in version 2.5.3
 ------------------------
 - MSnSet to/from SummarizedExperiment coercion (contributed by Arne
-  Smits in PR #284) <2017-12-17 Sun>
+  Smits in PR [#284](https://github.com/lgatto/MSnbase/issues/284)) <2017-12-17 Sun>
+- Fix inverted M/Z axis in plot3D,MSmap (reported by Sylvain
+  Dechaumet, see issue #292) <2017-12-19 Tue>
 
 Changes in version 2.5.2
 ------------------------

diff --git a/NEWS.md b/NEWS.md
@@ -3,6 +3,8 @@
 ## Changes in version 2.5.3
 - MSnSet to/from SummarizedExperiment coercion (contributed by Arne
   Smits in PR [#284](https://github.com/lgatto/MSnbase/issues/284)) <2017-12-17 Sun>
+- Fix inverted M/Z axis in plot3D,MSmap (reported by Sylvain
+  Dechaumet, see issue #292) <2017-12-19 Tue>
 
 ## Changes in version 2.5.2
 - Use automatic backend detection (based on file name and file

diff --git a/R/map.R b/R/map.R
@@ -94,12 +94,12 @@ setMethod("plot3D", "MSmap",
               if (rgl) {
                   if (!require("rgl"))
                       stop("The 'rgl' package needed. Install it with 'install.packages(\"rgl\")'.")
-                  rgl::plot3d(rev(dd$mz), dd$rt, dd$intensity, , type = "h",
+                  rgl::plot3d(dd$mz, dd$rt, dd$intensity, , type = "h",
                          xlab = "M/Z", ylab = "Retention time", zlab = "")
               } else {                  
                   ms <- NULL ## get rid of 'no visible global function definition' note
                   par.set <- list(box.3d = list(lwd=.2))
-                  cloud(intensity ~ rev(mz) + rt , data = dd,
+                  cloud(intensity ~ mz + rt , data = dd,
                         type="h",
                         scales= list(
                             arrows=FALSE,