fix(forEach): handle jQuery objects of length 0

Closes: angular#13169
lgalfaso · Oct 26, 2015 · dd58cc7 · dd58cc7
1 parent 2c8d87e
commit dd58cc7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/Angular.js b/src/Angular.js
@@ -193,7 +193,8 @@ msie = document.documentMode;
 
 function isNodeList(obj) {
   return typeof obj.length == 'number' &&
-         typeof obj.item == 'function';
+         (typeof obj.item == 'function' ||
+          isString(obj.jquery));
 }
 
 /**

diff --git a/test/AngularSpec.js b/test/AngularSpec.js
@@ -1142,6 +1142,11 @@ describe('angular', function() {
 
       forEach(jqObject, function(value, key) { log.push(key + ':' + value.innerHTML); });
       expect(log).toEqual(['0:s1', '1:s2']);
+
+      log = [];
+      jqObject = jqLite("<pane></pane>");
+      forEach(jqObject.children(), function(value, key) { log.push(key + ':' + value.innerHTML); });
+      expect(log).toEqual([]);
     });