silenced openssl x509 warning using -in #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per openssl/openssl#22893 we can use |
xry111
reviewed
Mar 14, 2024
xry111
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
LGTM.
@pierre-labastie Ok for a squash-and-merge and a new release?
|
I plan to merge this if there's no objection in a week. |
|
The proposed fix looks good (assuming it works, have not tested). I wanted to comment on the first proposed fix and note that it revealed another error that probably needs to be addressed (statically named tempfile). |
|
Should I add another commit to this PR addressing the statically named tempfile? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using make-ca, I had the warning for each cert described in issue #29
I tried using -in but still having it be piped to the openssl x509 command to no avail, so I put the result of the printf(...) to awkinputfile.awktmp so it can be used as an input file and thus silences the warning.
Does this work at all, both in terms of functionality and how any of you maintainers feel?
Tested the commit with OpenSSL 3.2.0, compiled using the LFS instructions - no warning regarding stdin, -in, and -new for me.