Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tokenize "exit" in fixed form parser #4485

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix: tokenize "exit" in fixed form parser #4485

merged 1 commit into from
Jul 11, 2024

Conversation

gxyd
Copy link
Contributor

@gxyd gxyd commented Jul 11, 2024

fixes #4469

Pranavchiku
Pranavchiku reviewed Jul 11, 2024
View reviewed changes
tests/fixed_form_with_exit.f
@@ -0,0 +1,6 @@
SUBROUTINE EXAMPLE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this example compiles, let's generate a full test that exists and test some variable using if( xx ) error stop as well.

Pranavchiku
Pranavchiku approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, I left a small comment regarding tests. Rest all is good.

@certik certik merged commit 3c76586 into lfortran:main Jul 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku approved these changes

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing error under --fixed-form-infer
3 participants
@gxyd @certik @Pranavchiku