feat: karnot quest visuals

[Marchand-Nicolas]

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced the QuestBanner component, displaying quest-related visuals and information.
  • Added a new JSON file containing quest banner details, enhancing quest representation.

• UI Enhancements

  • Integrated QuestBanner into the QuestDetails component for improved user experience.

• Style Updates

  • Updated CSS for the quest banner, ensuring responsive design and better visual presentation.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sepolia-starknet-quest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 30, 2024 0:27am
starknet-quest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 30, 2024 0:27am

[coderabbitai]

Walkthrough

A new React functional component named QuestBanner has been added, which displays a quest-related banner based on a provided questId. This component retrieves banner details from a newly introduced JSON file and renders a styled banner with an image, title, description, and a call-to-action button. The QuestBanner is integrated into the existing QuestDetails component without altering its original functionality. Additionally, several CSS classes have been added or modified to support the styling of the new banner component.

Changes

File	Change Summary
components/quests/questBanner.tsx	Introduced QuestBanner component; accepts questId prop, uses useMemo for banner details.
components/quests/questDetails.tsx	Imported and conditionally rendered QuestBanner within QuestDetails component.
public/utils/questbanners.json	Added new JSON file containing quest banner details with properties like questId, title, etc.
styles/quests.module.css	Added new CSS classes for the QuestBanner component and modified existing styles for responsiveness.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant QuestDetails
    participant QuestBanner
    participant JSONData

    User->>QuestDetails: View quest details
    QuestDetails->>JSONData: Fetch quest banner details
    JSONData-->>QuestDetails: Return banner details
    QuestDetails->>QuestBanner: Render QuestBanner with questId
    QuestBanner->>QuestBanner: Display banner with details
    QuestBanner-->>User: Show banner

Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @typescript-eslint/[email protected]
npm error Found: [email protected]
npm error node_modules/eslint
npm error dev eslint@"^9.11.1" from the root project
npm error peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/[email protected]
npm error node_modules/@eslint-community/eslint-utils
npm error @eslint-community/eslint-utils@"^4.2.0" from @typescript-eslint/[email protected]
npm error node_modules/@typescript-eslint/utils
npm error @typescript-eslint/utils@"5.62.0" from @typescript-eslint/[email protected]
npm error node_modules/@typescript-eslint/eslint-plugin
npm error dev @typescript-eslint/eslint-plugin@"^5.47.0" from the root project
npm error 1 more (eslint-config-next)
npm error 1 more (@typescript-eslint/type-utils)
npm error @eslint-community/eslint-utils@"^4.2.0" from [email protected]
npm error 5 more (@typescript-eslint/type-utils, ...)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0" from @typescript-eslint/[email protected]
npm error node_modules/@typescript-eslint/eslint-plugin
npm error dev @typescript-eslint/eslint-plugin@"^5.47.0" from the root project
npm error @typescript-eslint/eslint-plugin@"^5.4.2 || ^6.0.0 || ^7.0.0 || ^8.0.0" from [email protected]
npm error node_modules/eslint-config-next
npm error dev eslint-config-next@"^14.0.1" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/eslint
npm error peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0" from @typescript-eslint/[email protected]
npm error node_modules/@typescript-eslint/eslint-plugin
npm error dev @typescript-eslint/eslint-plugin@"^5.47.0" from the root project
npm error @typescript-eslint/eslint-plugin@"^5.4.2 || ^6.0.0 || ^7.0.0 || ^8.0.0" from [email protected]
npm error node_modules/eslint-config-next
npm error dev eslint-config-next@"^14.0.1" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /root/.npm/_logs/2024-11-30T12_25_20_698Z-eresolve-report.txt
npm error A complete log of this run can be found in: /root/.npm/_logs/2024-11-30T12_25_20_698Z-debug-0.log

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 5

🧹 Outside diff range and nitpick comments (2)

styles/quests.module.css (2)

304-316: Consider using CSS Grid for better layout control.

The current flex-based layout could be improved using CSS Grid for better control over the banner's aspect ratio and responsiveness.

 .questBanner {
   max-width: 90%;
   width: 728px;
   margin-top: 1.5rem;
   background-color: var(--menu-background);
   box-shadow: 0px 2px 30px rgba(16, 16, 18, 0.06);
   border-radius: 8px;
-  display: flex;
-  align-items: stretch;
+  display: grid;
+  grid-template-columns: 201px 1fr;
   height: 201px;
 }

---

433-444: Optimize mobile breakpoint transitions.

The mobile layout transition could be smoother by using intermediate breakpoints and considering tablet layouts.

Consider adding an intermediate breakpoint at 960px for tablets:

+@media screen and (max-width: 960px) {
+  .questBanner {
+    grid-template-columns: 150px 1fr;
+    height: 180px;
+  }
+
+  .questBannerImage {
+    width: 150px;
+  }
+}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0716060 and 0d7c718.

⛔ Files ignored due to path filters (2)

• public/karnot/KarnotxSTRKFarm.png is excluded by !**/*.png
• public/karnot/xSTRK.png is excluded by !**/*.png

📒 Files selected for processing (4)

• components/quests/questBanner.tsx (1 hunks)
• components/quests/questDetails.tsx (2 hunks)
• public/utils/questbanners.json (1 hunks)
• styles/quests.module.css (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• public/utils/questbanners.json

[fricoben]

lgtm