Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: use server endpoint instead of starkscan api #295

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

irisdv
Copy link
Collaborator

@irisdv irisdv commented Oct 27, 2023

Part of lfglabs-dev/api.starknet.quest#115

We need to wait for the api to be updated before merging this PR

@irisdv irisdv requested a review from fricoben October 27, 2023 09:07
@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goerli-starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 5:22pm
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 5:22pm

Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just something to delete

if (data.data[0].timestamp) {
const sinceData = memberSince(data.data[0].timestamp);
.then((data: DeployedTime | QueryError) => {
console.log(data);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to delete

@fricoben fricoben added ❌ Change request Change requested from reviewer and removed 🔥 Ready for review This pull request needs a review labels Oct 27, 2023
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fricoben fricoben merged commit 887e344 into testnet Oct 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants