Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding blur and fixing footer in category details #209

Merged
merged 2 commits into from
Oct 15, 2023
Merged

fix: adding blur and fixing footer in category details #209

merged 2 commits into from
Oct 15, 2023

Conversation

Marchand-Nicolas
Copy link
Collaborator

close: #191

@vercel
Copy link

vercel bot commented Oct 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goerli-starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 2:26pm
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 2:26pm

@Marchand-Nicolas Marchand-Nicolas changed the title Adding blur and fixing footer fix: adding blur and fixing footer in category details Oct 7, 2023
@fricoben fricoben requested a review from irisdv October 8, 2023 09:11
irisdv
irisdv approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@irisdv irisdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Kevils
Kevils requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@Kevils Kevils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capture d’écran 2023-10-09 à 09 54 23

  • Ajouter du padding ou margin entre le footer et les cards quests. Sur le design j'ai mis 48px bottom pour la section card et 64px top pour le footer

@Kevils Kevils added the 🚧 In progress do not merge Pull Request in progress, please do not merge label Oct 9, 2023
@Marchand-Nicolas Marchand-Nicolas added 🔥 Ready for review This pull request needs a review and removed 🚧 In progress do not merge Pull Request in progress, please do not merge labels Oct 11, 2023
Kevils
Kevils approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@Kevils Kevils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect ! thanks :)

@fricoben fricoben merged commit 7d75629 into testnet Oct 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kevils Kevils Kevils approved these changes

@irisdv irisdv irisdv approved these changes

Assignees
No one assigned
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Footer in category detail
4 participants
@Marchand-Nicolas @irisdv @Kevils @fricoben