Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add nft view in profile #190

Merged
merged 9 commits into from
Oct 5, 2023
Merged

feat: add nft view in profile #190

merged 9 commits into from
Oct 5, 2023

Conversation

irisdv
Copy link
Collaborator

@irisdv irisdv commented Oct 3, 2023

Close #148

@vercel
Copy link

vercel bot commented Oct 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goerli-starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 1:38pm
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 1:38pm

fricoben
fricoben requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes and questions

components/lands/land.tsx Outdated Show resolved Hide resolved
pages/[addressOrDomain].tsx Outdated Show resolved Hide resolved
pages/[addressOrDomain].tsx Outdated Show resolved Hide resolved
Kevils
Kevils requested changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@Kevils Kevils left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

1 - Passer la typographie des deux chips en micro medium (12px semi bold)

Capture d’écran 2023-10-03 à 11 33 53

1 - Est-ce qu'on peut fill l'image sur la largeur ?
2 - Quand il y a une seule card, est-ce qu'on peut la centre comme le contenu du haut ?

Merci c'est top ! 🙂

fricoben
fricoben approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Kevils Kevils self-requested a review October 4, 2023 19:52
Kevils
Kevils approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@Kevils Kevils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@irisdv irisdv merged commit 74f4ce6 into testnet Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kevils Kevils Kevils approved these changes

@fricoben fricoben fricoben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NFTs & Achievements view on profil
3 participants
@irisdv @fricoben @Kevils