Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skeletons achievements & update navbar title #179

Merged
merged 2 commits into from
Oct 2, 2023
Merged

fix: skeletons achievements & update navbar title #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
295debc
fix: skeletons achievements + update navbar title
irisdv Oct 2, 2023
9f73cbe
fix: loading achievements
irisdv Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/UI/navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ const Navbar: FunctionComponent = () => {
<li className={styles.menuItem}>Achievements</li>
</Link>
<Link href={`/${address ? addressOrDomain : "not-connected"}`}>
<li className={styles.menuItem}>My profile</li>
<li className={styles.menuItem}>My land</li>
</Link>
{/* Note: I'm not sure that our testnet will be public so we don't show any link */}
{/* <SelectNetwork network={network} /> */}
Expand Down Expand Up @@ -286,7 +286,7 @@ const Navbar: FunctionComponent = () => {
onClick={() => setNav(false)}
className={styles.menuItemSmall}
>
My profile
My land
</li>
</Link>
</ul>
Expand Down
4 changes: 3 additions & 1 deletion components/skeletons/achievementSkeleton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,19 @@ const AchievementSkeleton: FunctionComponent = () => {
<Skeleton
variant="rounded"
className={styles.achievementLoading}
height={200}
sx={{
bgcolor: "grey.900",
borderRadius: "30px",
margin: "40px auto 0",
margin: "40px auto",
}}
/>
</div>
<div className={styles.achievementSkeleton}>
<Skeleton
variant="rounded"
className={styles.achievementLoading}
height={200}
sx={{
bgcolor: "grey.900",
borderRadius: "30px",
Expand Down
2 changes: 1 addition & 1 deletion pages/achievements.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const Achievements: NextPage = () => {
setHasChecked(true);
});
}
}, [userAchievements.length, hasChecked]);
}, [userAchievements.length, hasChecked, address]);

return (
<div className={styles.screen}>
Expand Down