Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: domain popup #171

Merged
merged 7 commits into from
Sep 30, 2023
Merged

feat: domain popup #171

merged 7 commits into from
Sep 30, 2023

Conversation

Marchand-Nicolas
Copy link
Collaborator

close: #147

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goerli-starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2023 10:29am
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2023 10:29am

Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super Cool ! Some Important code changes needed :)

components/UI/navbar.tsx Outdated Show resolved Hide resolved
components/UI/menus/popup.tsx Outdated Show resolved Hide resolved
components/UI/navbar.tsx Outdated Show resolved Hide resolved
onClick={() => window.open("https://app.starknet.id/")}
onClose={() => setShowDomainPopup(false)}
/>
) : null}
<div className="flex">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it here too ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because in the issue it is written "When the user wants to claim a reward after completing the quest or to connect wallet and doesn't have a domain, they are prompted to get one through a popup that redirects them to the Starknet ID page. When the user doesn't have a domain yet, a "Get Your Domain" button is visible on their profile."
So that's why I am also showing the popup when trying to claim a reward

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok i see to me you can delete that because we'll make indispensable once the guy is connected on the quest page and can not close it.

banner="/visuals/profile.webp"
description="To access Starknet Quest, you must own a Starknet domain. It's your passport to the Starknet ecosystem. Get yours now."
buttonName="Get a Starknet Domain"
onClick={() => window.open("https://app.starknet.id/")}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to check if we're on testnet or not

components/UI/navbar.tsx Outdated Show resolved Hide resolved
import { StarknetIdJsContext } from "../context/StarknetIdJsProvider";
import { hexToDecimal } from "../utils/feltService";

export default function useHasDomain(address: string | BN | undefined) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useHasRootDomain :)

Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a last comment

Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup domain
2 participants