-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add achievements page #130
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pages/achievements.tsx
Outdated
setHasChecked(true); | ||
}); | ||
} | ||
}, [userAchievements, address, hasChecked]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally have everything on completed: false
even tho I have some of the NFTs
components/UI/footer.tsx
Outdated
|
||
const Footer: FunctionComponent = () => { | ||
return ( | ||
<div className="relative"> | ||
<footer className={styles.footer}> | ||
Powered by <strong>Starknet</strong> | ||
<Link href="/partnership">Partnership</Link> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not see this component anywhere, this is normal right ? I prefer this to be hidden atm as I told you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was already a footer that existed in the code that was not shown anywhere, I started updating it but I can revert this changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good ! Some comments :)
index % 2 === 0 ? "right center" : "left center" | ||
}`, | ||
backgroundSize: "30%", | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth putting that in a const before the return
components/achievements/level.tsx
Outdated
achievement: AchievementDocument; | ||
}; | ||
|
||
const CustomTooltip = styled(({ className, ...props }: TooltipProps) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a component in /UI
pages/achievements.tsx
Outdated
<div className={styles.headerContent}> | ||
<h1 className={styles.title}>Achievements</h1> | ||
<p className={styles.subtitle}> | ||
Earn achievements to unlock lands and showcase them on your profile! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earn achievements to unlock lands and showcase them on your profile!
==> Complete achievements and grow your Starknet on-chain reputation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not using webp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because it doesn't work as a background image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and comments 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Closes #126