Skip to content

Commit

Permalink
Merge pull request #179 from starknet-id/feat/implement_new_quests_sept
Browse files Browse the repository at this point in the history
fix: skeletons achievements & update navbar title
  • Loading branch information
fricoben authored Oct 2, 2023
2 parents 85ab075 + 9f73cbe commit 35391b9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions components/UI/navbar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ const Navbar: FunctionComponent = () => {
<li className={styles.menuItem}>Achievements</li>
</Link>
<Link href={`/${address ? addressOrDomain : "not-connected"}`}>
<li className={styles.menuItem}>My profile</li>
<li className={styles.menuItem}>My land</li>
</Link>
{/* Note: I'm not sure that our testnet will be public so we don't show any link */}
{/* <SelectNetwork network={network} /> */}
Expand Down Expand Up @@ -286,7 +286,7 @@ const Navbar: FunctionComponent = () => {
onClick={() => setNav(false)}
className={styles.menuItemSmall}
>
My profile
My land
</li>
</Link>
</ul>
Expand Down
4 changes: 3 additions & 1 deletion components/skeletons/achievementSkeleton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,19 @@ const AchievementSkeleton: FunctionComponent = () => {
<Skeleton
variant="rounded"
className={styles.achievementLoading}
height={200}
sx={{
bgcolor: "grey.900",
borderRadius: "30px",
margin: "40px auto 0",
margin: "40px auto",
}}
/>
</div>
<div className={styles.achievementSkeleton}>
<Skeleton
variant="rounded"
className={styles.achievementLoading}
height={200}
sx={{
bgcolor: "grey.900",
borderRadius: "30px",
Expand Down
2 changes: 1 addition & 1 deletion pages/achievements.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const Achievements: NextPage = () => {
setHasChecked(true);
});
}
}, [userAchievements.length, hasChecked]);
}, [userAchievements.length, hasChecked, address]);

return (
<div className={styles.screen}>
Expand Down

1 comment on commit 35391b9

@vercel
Copy link

@vercel vercel bot commented on 35391b9 Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.