Fix: Added more collections to the NFTcollections const in constants.ts

[abdegenius]

Added more collections to the NFTcollections const in constants.ts

Close #912 .

Summary by CodeRabbit

• New Features
  • Expanded the NFT collections list by adding five new collections: "Starkpunks," "Persona by XAR," "Alter Nova," "Ventorians NFT Collection," and "Everai," each with unique images and external links for more engaging content.

[vercel]

@abdegenius is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 22, 2024 1:58pm

[coderabbitai]

Walkthrough

The changes in this pull request involve the addition of five new NFT collections to the NftCollections array within the utils/constants.ts file. Each new collection includes properties such as imageUri, name, and externalLink. The newly added collections are "Starkpunks," "Persona by XAR," "Alter Nova," "Ventorians NFT Collection," and "Everai." No other modifications were made to existing constants or structures.

Changes

File	Change Summary
utils/constants.ts	Added five new entries to the NftCollections array with imageUri, name, and externalLink properties for each collection.

Assessment against linked issues

Objective	Addressed	Explanation
Add new collection recommendations (Issue #912)	✅
Ensure collections render correctly on the specified page	❌	Rendering on the page has not been verified.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 58149d6 and f12b8da.

📒 Files selected for processing (1)

• utils/constants.ts (1 hunks)

🔇 Additional comments (2)

utils/constants.ts (2)

41-42: Verify collection name consistency with marketplace

The collection names in the code differ slightly from their marketplace URLs:

• "Starkpunks" → "starkpunks"
• "Persona by XAR" → "personaxar"
• "Alter Nova" → "alternovaxyz"

While this is likely intentional (matching marketplace slugs), please verify these are the official collection names as they appear on Element Market.

Also applies to: 47-48, 53-54

✅ Verification successful

Collection names and URLs are correctly configured

The collection names and their corresponding Element Market URLs in the constants file are accurate and intentionally different:

• The display names use proper capitalization and spacing for UI presentation (e.g., "Starkpunks", "Persona by XAR")
• The URLs use lowercase, URL-friendly slugs that match Element Market's collection URLs (e.g., "starkpunks", "personaxar")
• Additional collection details like "NFT Collection" in "Ventorians NFT Collection" and "-starknet" in "everai-starknet" URLs are also correctly mapped

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for any other references to these collection names in the codebase

echo "Searching for collection name references..."
collections=("Starkpunks" "Persona by XAR" "Alter Nova" "Ventorians" "Everai")

for collection in "${collections[@]}"; do
    echo "References to '$collection':"
    rg -i "$collection" --type ts --type tsx
done

Length of output: 1076

---

Script:

#!/bin/bash
# Let's try with just the typescript type since tsx isn't recognized
echo "Searching for collection name references..."
collections=("Starkpunks" "Persona by XAR" "Alter Nova" "Ventorians" "Everai")

for collection in "${collections[@]}"; do
    echo "References to '$collection':"
    rg -i "$collection" --type ts
done

# Let's also check the actual constants file to see the full context
echo -e "\nChecking constants file content:"
cat utils/constants.ts

Length of output: 8569

---

38-67: LGTM! Verify URL accessibility

The structure of the new entries is consistent with existing collections. However, let's verify the accessibility and security of the image URLs.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[fricoben]

lgtm