ref: identity warnings

[fricoben]

Domain is subscribed but we still show the warning so I fixed it

Summary by CodeRabbit

• New Features

  • Enhanced expiry warning logic in the Identities Gallery, now requiring both imminent expiry and domain inclusion in the auto-renewal list for display.

• Bug Fixes

  • Improved accuracy of expiry warnings, ensuring users receive timely notifications based on updated conditions.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 23, 2024 6:36pm
sepolia-app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 23, 2024 6:36pm

[coderabbitai]

Walkthrough

The changes introduce a refined conditional check in the IdentitiesGalleryV1 component for rendering the expiry warning. The warning is now displayed only if the identity is expiring soon and its domain is included in the needAutoRenewal array. This adjustment enhances the control flow by adding an additional condition for when the expiry warning should be shown.

Changes

File	Change Summary
components/identities/identitiesGalleryV1.tsx	Added a conditional check to refine when the expiry warning is rendered based on two criteria: the identity must be expiring soon and its domain must be in the needAutoRenewal array.

Possibly related PRs

• fix: subscription calldata #859: The changes in the Subscription component involve adding additional checks to the control flow, similar to the conditional check introduced in the IdentitiesGalleryV1 component for rendering the expiry warning. Both PRs enhance the logic for displaying user feedback based on specific conditions.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

components/identities/identitiesGalleryV1.tsx (1)

62-63: Approved: Improved warning display logic

The changes effectively address the issue mentioned in the PR description. The expiry warning is now only shown for domains that both need auto-renewal and are expiring soon, which should resolve the inconsistency where warnings were displayed for subscribed domains.

For improved readability, consider extracting the condition into a separate variable with a descriptive name. For example:

const shouldShowExpiryWarning = needAutoRenewal?.includes(identity.domain) && isIdentityExpiringSoon(identity);

{shouldShowExpiryWarning ? (
  // ... existing warning JSX ...
) : null}

This would make the code more self-documenting and easier to understand at a glance.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b59245a and 17bcb10.

Files selected for processing (1)

• components/identities/identitiesGalleryV1.tsx (1 hunks)

Additional comments not posted (2)

components/identities/identitiesGalleryV1.tsx (2)

Line range hint 1-189: Summary: Focused change addressing the warning display issue

The changes in this file are minimal and targeted, addressing the specific issue mentioned in the PR description. The modification to the conditional rendering of the expiry warning should resolve the inconsistency where warnings were displayed for subscribed domains.

The rest of the file remains unchanged, and the overall structure and logic of the IdentitiesGalleryV1 component are intact. The changes are well-integrated and don't appear to introduce any new issues or require modifications to other parts of the component.

---

62-63: Verify related implementations

While the changes look good, it's important to ensure that the supporting implementations are correct:

1. Verify that the isIdentityExpiringSoon function in the dateService utility file is correctly implemented.
2. Confirm that the API endpoint for fetching non-subscribed domains (/renewal/get_non_subscribed_domains) is returning the expected data.
3. Check if there's appropriate error handling for the API call in the useEffect hook.

To assist with this verification, you can run the following script:

This script will help us verify the implementation of the isIdentityExpiringSoon function, the API call, and the error handling in the useEffect hook.

[Marchand-Nicolas]

Lgtm