Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 404.tsx image #911

Closed
1 task
fricoben opened this issue Nov 15, 2024 · 42 comments · Fixed by #922
Closed
1 task

Change 404.tsx image #911

fricoben opened this issue Nov 15, 2024 · 42 comments · Fixed by #922
Assignees
Labels
Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack Open for contribution An issue that is available for an Only Dust contribution

Comments

@fricoben
Copy link
Contributor

Description 📹

Our current error illustration is used for 404.tsx when it's not expressive for the 404 situation so I created a dedicated 404illu.webp image that you can find here that need to replacte the current errorIllu.webp

404.zip

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:

  • Change errorIllu.web to 404illu.webp in 404.tsx
  1. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:
    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

@fricoben fricoben added Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack Open for contribution An issue that is available for an Only Dust contribution labels Nov 15, 2024
@0xdevcollins
Copy link

Can I work on this, please?

@Villarley
Copy link

Villarley commented Nov 19, 2024

hi @fricoben 🚀,
I’m Santiago Villarreal, a proactive and communicative developer with experience in both front-end and back-end Web3 development. I’m a proud member of Dojo Coding and have worked on various projects built on StarkNet and Stellar, where I actively contributed to creating scalable and efficient solutions. I also won a Web3 hackathon, Buildathon, for my work on BuildMyEvent, an open-source blockchain project focused on solving real-world challenges and integrating useful features.

For this issue, I’ll replace the current errorIllu.webp with the newly provided 404illu.webp in 404.tsx to ensure the illustration aligns better with the situation. I'll commit to the project structure and deliver the solution in the estimated time with the estimated quality. I already contributed to other projects of lfglabs with a successful journey.
Pls feel free to reach out anytime!

@PedroCo3lho
Copy link

Can I work on this task?
ETA 1 hour

@vestor-dev
Copy link

Hey @fricoben please let me handle this issue :)
I would like to contribute to this repo
Eta: 2hrs

@abdegenius
Copy link
Contributor

I can comfortably handle this issues

@Steph3097
Copy link

Hello! My name is Sttef and i have over 5 years of experience in front end development, with experience on typescript, react, javascript and using tools like figma and zeplin

I’m part of the Dojo team ⛩️

I would like to be part of this issue! I will change the image as requested and follow the steps you mentioned!

Thank you!

@TheSQLguy
Copy link

gm @fricoben, i have skills in python, js and ts, and i am a newcomer here. I'd love to start my journey with od :)

2 similar comments
@TheSQLguy
Copy link

gm @fricoben, i have skills in python, js and ts, and i am a newcomer here. I'd love to start my journey with od :)

@TheSQLguy
Copy link

gm @fricoben, i have skills in python, js and ts, and i am a newcomer here. I'd love to start my journey with od :)

@starknetbrother
Copy link

I'm a new contributor and would love to work on this

@TheSQLguy
Copy link

gm @fricoben, i have skills in python, js and ts, and i am a newcomer here. I'd love to start my journey with od :)

@0xLemonn
Copy link

i am a backend dev adept in js,ts and python, a newcomer here, and willing to contribute.

1 similar comment
@0xLemonn
Copy link

i am a backend dev adept in js,ts and python, a newcomer here, and willing to contribute.

@Akshola00
Copy link

Can I take this from here?

@Unickhub
Copy link

I’d like to work on this.

@josephchimebuka
Copy link

Mind if I take this issue?

@BrunoAmbricca
Copy link

I would like to work on this issue

@Yunusabdul38
Copy link

I’d like to resolve this.

@Thibrac
Copy link

Thibrac commented Nov 21, 2024

I'd be happy to do this.

@Steph3097
Copy link

Hello! My name is Sttef and i have over 5 years of experience in front end development, with experience on typescript, react, javascript and using tools like figma and zeplin

I’m part of the Dojo team ⛩️

I would like to be part of this issue! I will change the image as requested and follow the steps you mentioned!

Thank you!

@ryzen-xp
Copy link

Hi, I am proficient Blockchain developer expert in Cairo , Rust and Solidity and also in web development.
I have contributed many stark net project and more . please /assign this issue .
Thank You
ETA : 48 hours

@SudiptaPaul-31
Copy link

Will love to work on this issue.

My approach to tackle this issue:

Will check first both the error images present and then will check at where its being rendered and will eventually remove the older one and add the new one and check that if its working properly or not and finally end by making a pr.

ETA-1Day

@Benjtalkshow
Copy link

Can I contribute to this one?

@ShantelPeters
Copy link

Could I take a shot at this?

@Michaelkingsdev
Copy link

Can I handle this task?

@GideonBature
Copy link
Contributor

Would love to tackle this!

My name is Gideon Bature, a Software Engineer with experience using TypeScript/JavaScript with ReactJS. If assigned this issue, I will send my first PR within 48 hrs.

Thank you!

@DanielEmmanuel1
Copy link

I’m interested in this one.
I can have this delivered in 24 hrs

@Ekene001
Copy link

Hi, I'm Ekene, a frontend and blockchain developer, and I’m new to the OnlyDust platform. This is my first time contributing to this repository, and I’m excited about the opportunity to collaborate and bring my skills to the table. Looking forward to making a positive impact and working with the team!

To tackle this issue, I will replace the current error illustration used for the 404 error page with the new, more expressive 404illu.webp image you provided. I will start by identifying the location of the current errorIllu.webp image within the project and then ensure that the new image file is correctly placed in the appropriate directory.

Next, I will update the 404.tsx page to reference the new 404illu.webp image instead of the old one. This will involve updating the image source path and ensuring the styling aligns with the design of the new illustration. I will also double-check that the new image is responsive and properly displayed across different screen sizes.

After implementing the changes, I will test the 404 error page to ensure the new image is correctly displayed when a 404 error occurs and verify that no other parts of the page are affected by this update.

@melnikga
Copy link

I'd like to take this issue.
Hi, my name is Georgiy, I'm a fullstack blockchain developer. I have extensive experience in developing tools for Starknet, and I've participated in almost all ODHacks, during which I worked on many projects. My OnlyDust profile: https://app.onlydust.com/u/melnikga

@morelucks
Copy link

Let me try this one!

@OWK50GA
Copy link

OWK50GA commented Nov 21, 2024

May I pick this up?

@imoleayomi19
Copy link

May I handle this issue? Yes
I am a Front-end developer. I am proficient in CSS, Typescript, JavaScript, Solidity.
I would love to work on this project.

@emmz3230
Copy link

I am a front-end developer specializing in responsive web design,
device-compatible email templates, 3D web integration,
and technical writing on programming topics. I also contribute
to open-source documentation and help build documentation sites.

i will remove and add the newly proposed image for the 404 page and if possible, add animation

Thanks

@martinvibes
Copy link

Can I take care of this issue?
i'm a frontend dev and a blockchain dev please kindly assign :)

@LazarusAA
Copy link

Hi! I'm Alvaro Lazarus, a developer from Dojo Coding ⛩️. This looks like a straightforward and fun task to work on, and I’d love to take it on. I’m detail oriented and familiar with making targeted updates like this, so I’m confident I can handle it smoothly.

My workflow:

  • Replace errorIllu.webp with 404illu.webp in 404.tsx.
  • Test to ensure functionality remains intact.
  • Commit changes with a clear message.
  • Follow PR guidelines for submission and review.

ETA: 24 hrs

@Amarjeet325
Copy link
Contributor

Can I take this from here?

@Supa-mega
Copy link

Could I take a shot at this?

@Emmanex01
Copy link

Hi, I’m interested in this one. Would you mind assigning it to me.

@sandragcarrillo
Copy link

I would love to contribute to this issue, I have experience as a frontend developer.

@Kaminar-i
Copy link

Mind if I take this issue?
i'm new and would love to work on this
please assign me

@t0fudev
Copy link

t0fudev commented Nov 22, 2024

Hello! My name is t0fudev, and I am a computer science student, a Dojo Coding member and a Web3 developer with some experience working on the frontend of different projects. I am eager to apply my skills and contribute to this amazing project.

I would work on this issue by following the required process according to the project's description in order to make the change with the corresponding image ensuring that it works correctly. And if there's any doubt I would ask inmmediately to maintainers for help.

I would be honored to contribute to this issue and make a meaningful impact on the project. Thank you for considering my application and I sincerely appreciate your time and the opportunity.

@zleypner
Copy link

Hi! I’m Anwar a Software Developer with +3 years of experience,
I would love to get assigned with this issue

@onlydustapp onlydustapp bot assigned Amarjeet325 and Kaminar-i and unassigned Kaminar-i Nov 22, 2024
fricoben pushed a commit that referenced this issue Nov 23, 2024
* fix:Change errorIllu.web to 404illu.webp in 404.tsx

* Fix:Change 404.tsx image by 404illu.webp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack Open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.