Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTI and federate socket fixes #422

Merged
merged 4 commits into from
May 13, 2024
Merged

RTI and federate socket fixes #422

merged 4 commits into from
May 13, 2024

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj requested a review from edwardalee May 10, 2024 14:58
@lhstrh lhstrh enabled auto-merge May 10, 2024 17:40
edwardalee
edwardalee requested changes May 11, 2024
View reviewed changes
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except that I think the RTI should not exit if it fails to drain the socket connecting it to a federate that is no longer connected?

core/federated/RTI/rti_remote.c Show resolved Hide resolved
@lhstrh lhstrh added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 2318dad May 13, 2024
28 checks passed
@erlingrj erlingrj deleted the fed-socket-fixes branch May 13, 2024 13:35
@erlingrj erlingrj mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
bugfix federated RTI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlingrj @edwardalee @lhstrh