-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python Target] CARLA Demo #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be some code duplication between carla_circle.lf
and carla_manual_control.lf
. You could fix that by factoring out the Python code into a separate file as illustrated here.
As is usually the case with duplication, you can probably solve this using composition by creating a class that is parameterized by a procedure that implements the behavior that is different between the two implementations. But I am happy with whatever you do as long as we are not stuck maintaining two copies of mostly the same code
Co-authored-by: Peter Donovan <[email protected]>
Thank you for the suggestions. I've factored out the Python code into a separate file. Please let me know if any additional changes are needed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! It looks like my comments have been addressed.
I see that this was merged, but |
This PR provides the code and instructions for running the CARLA simulator with Lingua Franca. For detailed guidance and troubleshooting, please refer to the README file.