Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Furuta pendulum example #20

Merged
merged 11 commits into from
Feb 13, 2023
Merged

Furuta pendulum example #20

merged 11 commits into from
Feb 13, 2023

Conversation

a-sr
Copy link
Contributor

@a-sr a-sr commented Jan 23, 2023

  • Moved the Furuta pendulum example to the regular examples structure
  • Added ReadMe files
  • Consolidated data output from simulation and plots

@a-sr a-sr requested a review from edwardalee January 23, 2023 14:45
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This works for me now. I've taken the liberty of adding @a-sr as an author.

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I left a few minor questions/suggestions.

C/src/modal_models/FurutaPendulum/FurutaPendulum.lf Outdated Show resolved Hide resolved
C/src/modal_models/FurutaPendulum/README.md Show resolved Hide resolved
C/src/modal_models/FurutaPendulum/README.md Outdated Show resolved Hide resolved
@edwardalee
Copy link
Contributor

@a-sr, Is this ready to merge? Seems so to me.

@a-sr
Copy link
Contributor Author

a-sr commented Feb 13, 2023

@edwardalee I agree.
I closed the last remaining discussions and will merge the PR now.

@a-sr a-sr merged commit 5280c2f into main Feb 13, 2023
@a-sr a-sr deleted the date23 branch February 13, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants