Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repaired export-dependency-graph property and dropped unsupported export-to-yaml property #2436

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Nov 14, 2024

Fixes #2434

@cmnrd cmnrd added cpp Related to C++ target bugfix labels Nov 14, 2024
Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you could handle this. Looks like export_dependency_graph is now called only after the program has completed? So you need to do Ctrl-C, or have timeout, or some other way of terminating the program before you get the graph?

@cmnrd
Copy link
Collaborator Author

cmnrd commented Nov 15, 2024

Yes, that is how it currently is and I think its good enough for now. Ideally, we would call the export before the execution starts, but currently the assembly of the port connections is tied in with the execute function. Separating it out is possible, but requires some more work.

@erlingrj erlingrj merged commit 58bb134 into master Nov 19, 2024
23 of 24 checks passed
@erlingrj erlingrj deleted the fix-dot-export branch November 19, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix cpp Related to C++ target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"export-dependency-graph" option is not working
2 participants