A target property for handling downstream next event tag (DNET) signal
#2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardalee
approved these changes
Oct 13, 2024
Comment on lines
4
to
5
| * If true, the RTI sends DNET signals during the execution of federation. The default is ture (for | ||
| * now, for testing). |
There was a problem hiding this comment.
Suggested change
| * If true, the RTI sends DNET signals during the execution of federation. The default is ture (for | |
| * now, for testing). | |
| * @brief Target property turning on or off the DNET signal optimization. | |
| * | |
| * If this target property is true, the RTI sends DNET (downstream next event tag) signals to an upstream federate | |
| * to tell the federate that sending LTC and NET signals with tags less than the specified value is unnecessary. | |
| * The default is true. |
Note that if we make the default value false, this feature will not be adequately tested. Is there any reason it should not be true by default?
There was a problem hiding this comment.
I updated the comment in 83bd58f.
I'm concerned that if every reaction sends a message every time it's triggered, the DNET may be useless. I'm trying to run some applications to see whether the impact is negligible, but I'm struggling to generalize the cases.
I'll make sure to show you a convincing result shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a target property for the signal
downstream next event tag. When the property is true, the federate launcher turns on the option DNET of the RTI.This PR is a companion PR of reactor-c#349.
There is another companion PR, lf-lang/reactor-ts#296.