Zephyr federated project #3
Conversation
| application/*/src-gen | ||
| application/*/fed-gen | ||
| application/*/bin | ||
| application/*/build | ||
| application/*/include | ||
| application/*/*build/** |
There was a problem hiding this comment.
| application/*/src-gen | |
| application/*/fed-gen | |
| application/*/bin | |
| application/*/build | |
| application/*/include | |
| application/*/*build/** | |
| **/src-gen | |
| **/fed-gen | |
| **/bin | |
| **/build | |
| **/include | |
| &{/leds} { | ||
| compatible = "gpio-leds"; | ||
| led-2 { | ||
| gpios = < &gpio9 0x19 GPIO_ACTIVE_HIGH >; | ||
| label = "User LED D34, GPIO9 AD 26"; | ||
| status = "okay"; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Isnt this part of the DTS of the dev-kit?
| &enet { | ||
| local-mac-address = [00 0a 35 00 00 02]; | ||
| status = "okay"; | ||
| }; |
There was a problem hiding this comment.
Do you have any idea how this is done for other boards? Do you have a link to where you found info about this?
| # Network application options and configuration | ||
| CONFIG_NET_CONFIG_SETTINGS=y | ||
| CONFIG_NET_CONFIG_NEED_IPV4=y | ||
| CONFIG_NET_CONFIG_MY_IPV4_ADDR="192.0.2.3" |
There was a problem hiding this comment.
It seems all parameters except this one, is common for both. Could they be extracted in a single common config file?
| exit(1) | ||
|
|
||
| class LfFedBuild(WestCommand): |
There was a problem hiding this comment.
This command seems to copy-and-paste a lot from the other build command. Would it be possible to combine them into a single command with additional options for building federates? Or, could we use the other lf-build command within this one?
| exit(1) | ||
|
|
||
| class LfFedFlash(WestCommand): |
There was a problem hiding this comment.
This command is very NXP EVK specific as it is using one particular flash/debug tool (pyOCD). As it is, I think it should be renamed to flash-evk or something. Alternatively we should look into how to make it more board independent.
Additions: