Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0-stable] mkimage-raw-efi: Find persist partition when installing into another disk #4283

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

rene
Copy link
Contributor

@rene rene commented Sep 24, 2024

Parent PR: #4277

When installing persist into another storage device, the installer script must search for the persist partition (and mount it) in the corresponding destination and not in the main storage device. This can be achieved by simply looking to INSTALL_PERSIST variable instead of INSTALL_DEV.

…disk

When installing persist into another storage device, the installer
script must search for the persist partition (and mount it) in the
corresponding destination and not in the main storage device. This can
be achieved by simply looking to INSTALL_PERSIST variable instead of
INSTALL_DEV.

Signed-off-by: Renê de Souza Pinto <[email protected]>
@rene rene requested review from deitch and eriknordmark September 24, 2024 08:32
@rene rene requested a review from zedi-pramodh as a code owner September 24, 2024 08:32
@github-actions github-actions bot requested a review from jsfakian September 24, 2024 08:33
Copy link
Member

@OhmSpectator OhmSpectator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change already looks good in the original PR.

@OhmSpectator
Copy link
Member

I want to merge it. But I think it would be strange to merge it earlier than the original PR.

@OhmSpectator OhmSpectator merged commit 8e15ac9 into lf-edge:12.0-stable Sep 25, 2024
31 checks passed
@rene rene deleted the fix-install-persist-12.0 branch October 11, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants