Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sql lookup template sql #3398

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Nov 25, 2024

No description provided.

Signed-off-by: Song Gao <[email protected]>
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.14%. Comparing base (410f52d) to head (adc04c2).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
extensions/impl/sql/lookupSource.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3398      +/-   ##
==========================================
+ Coverage   71.08%   71.14%   +0.05%     
==========================================
  Files         403      406       +3     
  Lines       46080    46427     +347     
==========================================
+ Hits        32754    33026     +272     
- Misses      10753    10811      +58     
- Partials     2573     2590      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <[email protected]>
@ngjaying ngjaying merged commit e795d19 into lf-edge:master Nov 26, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants