Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rest): convert to byte collector #3275

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

ngjaying
Copy link
Collaborator

@ngjaying ngjaying commented Oct 8, 2024

Support multiple formats like csv

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 74.46809% with 12 lines in your changes missing coverage. Please review.

Project coverage is 70.93%. Comparing base (dc7a770) to head (d4d3312).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/io/http/client.go 58.33% 7 Missing and 3 partials ⚠️
internal/io/http/rest_sink.go 94.12% 1 Missing ⚠️
internal/pkg/httpx/http.go 66.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3275      +/-   ##
==========================================
- Coverage   70.93%   70.93%   -0.00%     
==========================================
  Files         396      396              
  Lines       44604    44585      -19     
==========================================
- Hits        31638    31623      -15     
- Misses      10447    10452       +5     
+ Partials     2519     2510       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Support multiple formats like csv

Signed-off-by: Jiyong Huang <[email protected]>
@ngjaying ngjaying marked this pull request as ready for review October 8, 2024 10:12
@ngjaying ngjaying requested a review from Yisaer October 8, 2024 10:12
@ngjaying ngjaying merged commit ba4d475 into lf-edge:master Oct 9, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants