Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore sink ping #3220

Merged
merged 6 commits into from
Sep 24, 2024
Merged

fix: restore sink ping #3220

merged 6 commits into from
Sep 24, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Sep 24, 2024

No description provided.

Signed-off-by: Song Gao <[email protected]>
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 70.75%. Comparing base (c87824a) to head (6fdecc9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
extensions/impl/sql/sink.go 50.00% 4 Missing and 2 partials ⚠️
internal/server/meta_init.go 42.86% 3 Missing and 1 partial ⚠️
internal/topo/node/node.go 55.56% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3220      +/-   ##
==========================================
+ Coverage   70.72%   70.75%   +0.03%     
==========================================
  Files         396      396              
  Lines       44239    44267      +28     
==========================================
+ Hits        31287    31321      +34     
+ Misses      10456    10449       -7     
- Partials     2496     2497       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
@ngjaying ngjaying merged commit 4e98d72 into lf-edge:master Sep 24, 2024
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants