Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): restore rpc #3047

Merged
merged 1 commit into from
Jul 24, 2024
Merged

feat(cli): restore rpc #3047

merged 1 commit into from
Jul 24, 2024

Conversation

ngjaying
Copy link
Collaborator

No description provided.

Signed-off-by: Jiyong Huang <[email protected]>
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 26.81452% with 363 lines in your changes missing coverage. Please review.

Project coverage is 67.78%. Comparing base (88fd5da) to head (40c7b73).
Report is 60 commits behind head on master.

Files Patch % Lines
internal/server/rpc.go 51.37% 81 Missing and 43 partials ⚠️
internal/server/rpc_service.go 0.00% 65 Missing ⚠️
internal/server/rpc_plugin.go 0.00% 60 Missing ⚠️
internal/server/rpc_schema.go 0.00% 45 Missing ⚠️
internal/server/rpc_plugin_both.go 0.00% 37 Missing ⚠️
internal/server/rpc_plugin_hasnative.go 0.00% 31 Missing ⚠️
internal/io/sink/log_sink.go 66.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3047      +/-   ##
==========================================
- Coverage   67.97%   67.78%   -0.19%     
==========================================
  Files         353      380      +27     
  Lines       34242    36283    +2041     
==========================================
+ Hits        23273    24592    +1319     
- Misses       8898     9448     +550     
- Partials     2071     2243     +172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review July 24, 2024 03:35
@ngjaying ngjaying requested a review from Yisaer July 24, 2024 03:35
@ngjaying ngjaying merged commit ca5bd31 into lf-edge:master Jul 24, 2024
21 of 22 checks passed
578223592 pushed a commit to 578223592/ekuiper that referenced this pull request Sep 11, 2024
Signed-off-by: Jiyong Huang <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants