Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my attempt at fixing the "always green" build for 7.2 (mentioned in #1183 (comment))
Things done:
According to PHPUnit Bridge doc:
Allowing phpunit-bridge range of
"^4.4|^5.4|^6.0|^7.0"
together with--prefer-lowest
means that the 4.4.0 version of it is installed - which doesn't have all the required bugfixes.I've chosen ^7.0 as the latest one, for the 7.x series 7.0.1 is needed because it contains the bugfix for this issue: symfony/demo#1457 (comment)
The 7.2 build cannot use PHPUnit 9.5, it requires PHP 7.3
I've set this as max version instead - it will be used if possible, otherwise lower versions will be used.
One of the tests was failing:
This was fixed by bumping the version of lcobucci/jwt to 3.4.6 - I suspect it contains bugfix not present in 3.4.0
I found this issue when googling: shivammathur/setup-php#720
And it was right, all of a sudden the segmentation faults have disappeared.
Overall I feel everything I did was a bit hacky, but the build is now green 🎉