forked from highlight/highlight
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix hobby deploy routing logs/traces to self (highlight#7709)
## Summary When running the hobby deploy with `./run-hobby.sh`, logs and traces would be sent to the stack itself rather than to our cloud collector (when telemetry was enabled) because of the default value of the `OTLP_ENDPOINT`. Correct this to allow collecting phonehome telemetry data. Fixes recent regression that would prevent local dev from recording sessions. ## How did you test this change? before <img width="1707" alt="Screenshot 2024-02-08 at 12 34 33 PM" src="https://github.com/highlight/highlight/assets/1351531/53cbff5a-db7f-47ab-bf10-ac8a900be4c8"> after <img width="1604" alt="Screenshot 2024-02-08 at 12 36 29 PM" src="https://github.com/highlight/highlight/assets/1351531/3b57c5ea-ebbd-4013-b3f3-504705101036"> <img width="1565" alt="Screenshot 2024-02-08 at 12 36 17 PM" src="https://github.com/highlight/highlight/assets/1351531/50a7f0b4-1ce6-4db5-93f9-152f79e916ad"> https://www.loom.com/share/90b4ade1a6c749af93d10b8b54cbd35e ## Are there any deployment considerations? no ## Does this work require review from our design team? no
- Loading branch information
Showing
5 changed files
with
44 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
export const isOnPrem = import.meta.env.REACT_APP_IN_DOCKER | ||
export const isOnPrem = | ||
import.meta.env.PROD && import.meta.env.REACT_APP_IN_DOCKER |