Allow setting puppeteer headless mode in userConfig #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you find time, would be great if you could take a look @lewisdonovan (I cannot assign reviewers myself) |
|
Great find! Tested locally and it gives a performance boost of roughly 30%. I'll merge this now and update the NPM module shortly. |
lewisdonovan
pushed a commit
that referenced
this pull request
Mar 18, 2024
|
Latest version now available in NPM. To update please run |
|
Thanks a lot for the fast merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
headless: trueseems to have a significant performance impact over usingheadless: 'shell'.There is an issue in the puppeteer repository and during some testing, I found using
shellwas around 7-8 times faster for my queries.It would be great if one could set the puppeteer headless mode by defining it as an input argument.