Update Docker Build and Push action for ARM #141
Conversation
| - name: Build image | ||
| uses: docker/build-push-action@v5 |
There was a problem hiding this comment.
This should only be built for PRs. Please add a condition to this step.
| loadBalancerIP: "35.226.144.72" | ||
| # loadBalancerIP: "35.226.144.72" |
There was a problem hiding this comment.
Is this an intentional change?
There was a problem hiding this comment.
Yes, since we're hosted in Azure, we only need to pass an IP if we're assigning it a static, pre-allocated IP.
It's only being done manually for now.
I'll add the different IPs for crapi, crapi-dev and prod-demo to a cron workflow later.
| image: mailhog/mailhog | ||
| image: jcalonso/mailhog |
There was a problem hiding this comment.
Can we use official images? If not, would it be possible to build this image ourselves?
There was a problem hiding this comment.
It isn't.
But it's from a fork and has a million+ pulls on dockerhub.
Picked it up from here: mailhog/MailHog#359
We've been using it for the past couple of months now.
Question:
Do we need to save the different caches from every build and use just the last ones?
I used the
latesttag for the cache registries, so that we're storing it in the same image, and not hogging up storage space for cache that we might never use again.Update: Using
type=ghafor the docker cache now. Abolishing buildling crapi-image-cache on dockerhub