-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composition redesign #15
Conversation
* Converted project to ARC * Menu will generate delegate events for `will expand`, `did expand`, `will close`, and `did close`. * Menu will ask a delegate `should expand` and `should close` * Menu will generate events for `tap` and `long press` * Menu is populated from a Data Source Delegate * Menu is designed by a MenuItemFactory * Menu is composed with animations for expand, close, selected, unselected * Menu items will generate events for `tap` and `long press` * Menu items are designed by a MenuItemFactory * Menu items contain a `dataObject`
There was some code related to landing indexs and items that is now removed as it was being used for another branch of work .
Hello burtlo, |
Better gets the job done and I think your initial implementation does get the job done. So you are not obligated to act on the pull request. I simply wanted to share the design/refactoring with you and those that watch the project. I believe this implementation does appear heavier because there are more files. It also lacked an initialization with an array, which I added in the last commit. The concept of the |
* Created a protocol for a menu director which will layout the items in the menu. * Implmented the linear menu director * Initialization of the menu with a center point * Animations now maintain their own delays
How is this for awesome modularity? I created a protocol which is call the Previously an instance of the menu was limited to being radial. Now it can also be represented in a linear fashion with a simple command.
|
Thanks to @myStrom for implementing RNExpandingButtonBar which gave me the inspiration to extend QuadCurve further. |
Also removed mention of University as it was being default generated for me"
* duration and delay between each item * Set up a number of defaults * Allowed rotation and blowup/shrink scale configuration
your version crashed, |
I am able to reproduce it. I'll see what I can do to fix it. |
Give that a try. For some reason having a |
Instead of hard-coding the cant to the left or return to center the animations are now configurable through properties.
Main menu item animation is now configurable for expand/close |
It can not be merged... maybe I have updated something, Should I provide a link of your menu in the README.md? |
I really love the menu and wanted to use any data source (not just an array), more touch events, and the ability to manipulate the images and animations. I also wanted the menu items to be able to hold some data object that I could store and retrieve on selection instead of relying on an index.
Ultimately, feel free to ignore this pull request, I simply wanted to share with you the work as this likely may not be a goal you had in mind for your codebase.
will expand
,did expand
,will close
, anddid close
.should expand
andshould close
tap
andlong press
tap
andlong press
dataObject