-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Collection baking and some code styling #15
base: master
Are you sure you want to change the base?
Conversation
Moved Blender keywords into helper classes, so they can benefit from auto completion - not great design yet, but helps with readability.
Thank you for these improvements. I no longer get any of the errors I was getting before. |
I correct myself, I get Blender to crash when trying to bake multiple highpoly objects in a collection to a single lowpoly object in another collection. I'm attaching the simplest .blend file example that crashes for me. Crash log (Ubuntu Linux), Blender 2.92 and Blender 3.0 Output of the console
Example file |
Hey @Lamoot - is this crash specific to this branch or is it happening in the main branch as well? |
I tested it again with the main branch and it happens as well. Looks like it's not directly related to any of the changes you made here. |
from what i gathered after some testing its when the tool tries to make sure all the meshes in the collection are visible (lines 593 etc). I'm trying to figure out why that'd be causing any issues as it shouldn't do anything bad. |
Sounds great, thank you for looking into it. |
I'm in the middle of some other refactors, but wanted to make a PR to not run too far off before pushing further.
List of edits:
I tested all changes in Blender 2.93 with both object to object and collection to collection baking.