fix: decrease number of saves to MemGPTConfig #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to: #944 |
MemGPTConfig.save is called many times by quickstart and configure, resulting in confusing results. This collects changes and calls save once.
tombedor
force-pushed
the
tombedor.decrease-config-saves
branch
from
6606a19
to
68a0d5f
Compare
tombedor
commented
Feb 11, 2024
memgpt configure with existing values working as expected
|
clean install works as expected
|
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemGPTConfig.save is called many times by quickstart and configure,
resulting in confusing results. This collects changes and calls save once.