Cleanup preset configuration #287
Conversation
|
|
||
|
|
||
| @dataclass | ||
| class DefaultPreset(Preset): |
There was a problem hiding this comment.
I think this refactor is generally the right idea, however I wonder what the best way is to support users adding their own presets, eg: #282
I feel like adding presets should ideally be as easy as adding personas/humans or should have a similar workflow, where you create a text file and put it in a folder.
Thoughts?
There was a problem hiding this comment.
A lot of the code here look good (eg stripping preset to just take config as input), but we should hold until we refactor the preset creation based on #339, then rebase and merge this on top of the refactor (or the other way - open a PR with the refactor and merge this into the PR)
|
Closing b/c stale after presets refactor, though we may at some point want to add ideas from this PR into the existing refactor (eg adding a "pretty name" field to the preset YAML files). |
No description provided.