Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully catch errors when running agent.step() #216

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Gracefully catch errors when running agent.step() #216

merged 2 commits into from
Oct 31, 2023

Conversation

vivi
Copy link
Contributor

@vivi vivi commented Oct 31, 2023

We don't want exceptions from agent.step() to cause the CLI to exit and irrevocably lose conversation history.

  • Asks user if they want to retry upon failed step()
  • If user answers no, they are sent back to providing user input
image

@vivi vivi requested a review from cpacker October 31, 2023 08:33
@vivi
Copy link
Contributor Author

vivi commented Oct 31, 2023

Addresses #197.

cpacker
cpacker requested changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

memgpt/main.py Outdated Show resolved Hide resolved
memgpt/main.py Outdated Show resolved Hide resolved
@cpacker cpacker merged commit 4e6af2f into main Oct 31, 2023
1 check passed
@vivi vivi deleted the catch-step-errors branch October 31, 2023 20:33
@cpacker cpacker mentioned this pull request Oct 31, 2023
Closed
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
@vivi
Gracefully catch errors when running agent.step() (#216)
d6a4531 
* Gracefully catch errors when running agent.step()

* Modify retry message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpacker cpacker cpacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vivi @cpacker