fix: context window overflow patch #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…escription is null
…n. then also patch the create_tool path which is broken but was untested due to bad test.
cpacker
commented
Nov 18, 2024
cpacker
commented
Nov 18, 2024
| @@ -110,6 +112,7 @@ def print_tool(message: str): | |||
| assert tool.id == tool.id, f"Expected {tool.id} to be {tool.id}" | |||
|
|
|||
| # create agent with tool | |||
| assert tool.name is not None, "Expected tool name to be set" | |||
There was a problem hiding this comment.
(for typing purposes)
cpacker
commented
Nov 18, 2024
mattzh72
requested changes
Nov 18, 2024
…ential bad input runtime error
cpacker
commented
Nov 18, 2024
cpacker
commented
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problem where when the user set a lower than native context window limit, the loop runner wouldn't trigger the summarize event correctly (even though the summarizer warning would still get injected).