Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I made dump showing more messages and added a count (the last x) #204

Merged
merged 4 commits into from
Nov 4, 2023

Conversation

oderwat
Copy link
Contributor

@oderwat oderwat commented Oct 30, 2023

There seem to be some changes about the implementation so that the current dump message helper functions do not show a lot of useful info.

I changed it so that you can dump 5 (last 5 messages) and that it will print user readable output. This lets you get some more understanding about what is going on.

As some messages are still not shown I also show the index (reverse) of the printed message, so one can see what to "pop" to reach a special point without getting into the drumpraw.

Try it with something like /dump 10 which will show the last 10 messages in a nice readable way.

@oderwat
Copy link
Contributor Author

oderwat commented Oct 31, 2023

Rebase on main / black'ed and updated README.

There seem to be some changes about the implementation so that the
current dump message helper functions do not show a lot of useful info.

I changed it so that you can `dump 5` (last 5 messages) and that it will
print user readable output. This lets you get some more understanding about
what is going on.

As some messages are still not shown I also show the index (reverse) of the
printed message, so one can see what to "pop" to reach a special point
without geting into the drumpraw.
@oderwat
Copy link
Contributor Author

oderwat commented Nov 4, 2023

I find it quite disturbing that the current version of the application still just crashed with /dump1 and my changes did not get being considered. But now the code is rewritten in a way, that I don't even want to share my changes as a PR anymore.

@oderwat oderwat closed this Nov 4, 2023
@cpacker
Copy link
Collaborator

cpacker commented Nov 4, 2023

Hey @oderwat sorry we didn't get to this PR in a timely manner, we're just flooded with PRs and urgent feature requests that it's hard to keep track of what PRs can be easily merged or not and some things get lost.

Reopening to review and merge now.

@cpacker cpacker reopened this Nov 4, 2023
@cpacker
Copy link
Collaborator

cpacker commented Nov 4, 2023

Also in the future if you feel like we've lost track of a PR that we should be merging in ASAP, please feel free to bump the PR with a comment + @ us.

@cpacker
Copy link
Collaborator

cpacker commented Nov 4, 2023

Example output on /dump

image

@cpacker cpacker merged commit 0046ad9 into letta-ai:main Nov 4, 2023
1 of 2 checks passed
@cpacker
Copy link
Collaborator

cpacker commented Nov 4, 2023

Merging (test should pass once on main, should have an early exit for no key on fork PRs) - thank you for the contribution @oderwat

mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
* I made dump showing more message and added a count (the last x)

There seem to be some changes about the implementation so that the
current dump message helper functions do not show a lot of useful info.

I changed it so that you can `dump 5` (last 5 messages) and that it will
print user readable output. This lets you get some more understanding about
what is going on.

As some messages are still not shown I also show the index (reverse) of the
printed message, so one can see what to "pop" to reach a special point
without geting into the drumpraw.

* black

* patch

---------

Co-authored-by: Charles Packer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants