-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I made dump showing more messages and added a count (the last x) #204
Conversation
52a2acc
to
1e6dddc
Compare
d393a37
to
0168d62
Compare
Rebase on main / black'ed and updated README. |
There seem to be some changes about the implementation so that the current dump message helper functions do not show a lot of useful info. I changed it so that you can `dump 5` (last 5 messages) and that it will print user readable output. This lets you get some more understanding about what is going on. As some messages are still not shown I also show the index (reverse) of the printed message, so one can see what to "pop" to reach a special point without geting into the drumpraw.
0168d62
to
6184d3e
Compare
I find it quite disturbing that the current version of the application still just crashed with |
Hey @oderwat sorry we didn't get to this PR in a timely manner, we're just flooded with PRs and urgent feature requests that it's hard to keep track of what PRs can be easily merged or not and some things get lost. Reopening to review and merge now. |
Also in the future if you feel like we've lost track of a PR that we should be merging in ASAP, please feel free to bump the PR with a comment + @ us. |
Merging (test should pass once on main, should have an early exit for no key on fork PRs) - thank you for the contribution @oderwat |
* I made dump showing more message and added a count (the last x) There seem to be some changes about the implementation so that the current dump message helper functions do not show a lot of useful info. I changed it so that you can `dump 5` (last 5 messages) and that it will print user readable output. This lets you get some more understanding about what is going on. As some messages are still not shown I also show the index (reverse) of the printed message, so one can see what to "pop" to reach a special point without geting into the drumpraw. * black * patch --------- Co-authored-by: Charles Packer <[email protected]>
There seem to be some changes about the implementation so that the current dump message helper functions do not show a lot of useful info.
I changed it so that you can
dump 5
(last 5 messages) and that it will print user readable output. This lets you get some more understanding about what is going on.As some messages are still not shown I also show the index (reverse) of the printed message, so one can see what to "pop" to reach a special point without getting into the
drumpraw
.Try it with something like
/dump 10
which will show the last 10 messages in a nice readable way.