Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure typo patch #192

Merged
merged 2 commits into from
Oct 30, 2023
Merged

azure typo patch #192

merged 2 commits into from
Oct 30, 2023

Conversation

cpacker
Copy link
Collaborator

@cpacker cpacker commented Oct 30, 2023

Closes #176

@cpacker cpacker requested a review from vivi October 30, 2023 03:48
@cpacker
Copy link
Collaborator Author

cpacker commented Oct 30, 2023

@vivi black reverted ready for merge after check

cpacker
cpacker commented Oct 30, 2023
View reviewed changes
Copy link
Collaborator Author

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vivi
Copy link
Contributor

vivi commented Oct 30, 2023

😈 LGTM

@vivi vivi merged commit 52c6998 into main Oct 30, 2023
1 check passed
@cpacker cpacker deleted the azure-hotfix branch October 30, 2023 04:04
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
@cpacker @vivi
azure typo patch (#192)
b0b2710 
* azure typo patch

* Make azure embeddings var consistent

---------

Co-authored-by: Vivian Fang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivi vivi Awaiting requested review from vivi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Still facing the AZURE embedding issue
2 participants
@cpacker @vivi