-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Abstract Agent Class + Split Thread Agent #1700
Open
vivek3141
wants to merge
16
commits into
letta-ai:main
Choose a base branch
from
vivek3141:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpacker
changed the title
Abstract Agent Class + Split Thread Agent + CLI for Split Thread Agent
feat: Abstract Agent Class + Split Thread Agent + CLI for Split Thread Agent
Aug 30, 2024
Abstract agent class could look something like this: class BaseAgent(object):
def step(...) -> ...:
....
# Then update Agent to inherit from it
class Agent(BaseAgent):
...
# Also the SplitThreadAgent
class SplitThreadAgent(BaseAgent):
...
# And elsewhere in the code we can put in BaseAgent for the typing hint, e.g.:
def save_agent(agent: BaseAgent, ms: MetadataStore):
... |
vivek3141
changed the title
feat: Abstract Agent Class + Split Thread Agent + CLI for Split Thread Agent
feat: Abstract Agent Class + Split Thread Agent
Aug 31, 2024
cpacker
added a commit
that referenced
this pull request
Sep 13, 2024
cpacker
added a commit
that referenced
this pull request
Sep 13, 2024
Co-authored-by: vivek3141 <[email protected]>
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
Co-authored-by: vivek3141 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?
How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?
Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.
Related issues or PRs
Please link any related GitHub issues or PRs.
Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.
Additional context
Add any other context or screenshots about the PR here.