Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Abstract Agent Class + Split Thread Agent #1700

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

vivek3141
Copy link
Contributor

Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?

How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?

Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.

Related issues or PRs
Please link any related GitHub issues or PRs.

Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.

Additional context
Add any other context or screenshots about the PR here.

@cpacker cpacker self-requested a review August 30, 2024 20:40
@cpacker cpacker changed the title Abstract Agent Class + Split Thread Agent + CLI for Split Thread Agent feat: Abstract Agent Class + Split Thread Agent + CLI for Split Thread Agent Aug 30, 2024
@cpacker
Copy link
Collaborator

cpacker commented Aug 30, 2024

Abstract agent class could look something like this:

class BaseAgent(object):
    def step(...) -> ...:
       ....

# Then update Agent to inherit from it
class Agent(BaseAgent):
...

# Also the SplitThreadAgent
class SplitThreadAgent(BaseAgent):
...

# And elsewhere in the code we can put in BaseAgent for the typing hint, e.g.:
def save_agent(agent: BaseAgent, ms: MetadataStore):
...

@vivek3141 vivek3141 changed the title feat: Abstract Agent Class + Split Thread Agent + CLI for Split Thread Agent feat: Abstract Agent Class + Split Thread Agent Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants