-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor autogen agent to use sync memgpt, add notebook example #157
Conversation
2ffd8ed
to
4459051
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Need to check #164 |
@vivi can this be merged in? doesn't look like there are any blockers? |
memgpt/presets.py
Outdated
@@ -41,5 +42,36 @@ def use_preset(preset_name, model, persona, human, interface, persistence_manage | |||
first_message_verify_mono=True if "gpt-4" in model else False, | |||
) | |||
|
|||
if preset_name == "memgpt_chat_sync": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove duplicated lines 46-63?
memgpt/presets.py
Outdated
from .utils import printd | ||
|
||
|
||
DEFAULT = "memgpt_chat" | ||
SYNC_CHAT = "memgpt_chat_sync" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm understanding what "present" means, doesn't it make more sense to just pass in an async=True/False
into use_preset
? Since async/sync is orthogonal to what the OpenAI prompts are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4459051
to
6566d39
Compare
* Refactor autogen agent to use sync memgpt, add notebook example * Add colab badge to notebook * Update colab badge to point to main * Add imports lost in the merge * Changes to make autogenagent work with cli refactor
No description provided.