Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor autogen agent to use sync memgpt, add notebook example #157

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

vivi
Copy link
Contributor

@vivi vivi commented Oct 28, 2023

No description provided.

@vivi vivi requested a review from cpacker October 28, 2023 00:53
@vivi vivi marked this pull request as ready for review October 28, 2023 00:53
Copy link
Collaborator

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpacker
Copy link
Collaborator

cpacker commented Oct 29, 2023

Need to check #164

@cpacker
Copy link
Collaborator

cpacker commented Oct 30, 2023

@vivi can this be merged in? doesn't look like there are any blockers?

@@ -41,5 +42,36 @@ def use_preset(preset_name, model, persona, human, interface, persistence_manage
first_message_verify_mono=True if "gpt-4" in model else False,
)

if preset_name == "memgpt_chat_sync":
Copy link
Collaborator

@sarahwooders sarahwooders Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove duplicated lines 46-63?

from .utils import printd


DEFAULT = "memgpt_chat"
SYNC_CHAT = "memgpt_chat_sync"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm understanding what "present" means, doesn't it make more sense to just pass in an async=True/False into use_preset? Since async/sync is orthogonal to what the OpenAI prompts are.

Copy link
Contributor Author

@vivi vivi Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed once #154 is merged in. For now, this exists so that this change will work for autogen notebook users and not have any merge conflicts w/#154

(Once #154 is merged in, we'll change everything to point to SyncAgent)

@vivi vivi merged commit fa50644 into main Oct 31, 2023
1 check passed
@vivi vivi deleted the autogen-notebook branch October 31, 2023 04:33
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
* Refactor autogen agent to use sync memgpt, add notebook example

* Add colab badge to notebook

* Update colab badge to point to main

* Add imports lost in the merge

* Changes to make autogenagent work with cli refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants