-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Preset
routes to API + patch for tool_call_id
max length OpenAI error
#1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e off of Preset and only onto PresetModel?)
cpacker
changed the title
feat: add
feat: add Mar 20, 2024
Preset
routes to APIPreset
routes to API + patch for tool_call_id
max length OpenAI error
cpacker
commented
Mar 21, 2024
sarahwooders
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch for
tool_call_id
max length OpenAISeparately - this PR patches a new error introduced by an update to the OpenAI API, where they now require
tool_call_id
to be <= 29 characters.To fix this, the generate tool call ID helper function now trims a UUID to the max (OpenAI) length. For existing messages /
Message
objects, we now trim the strings at "runtime" (.to_openai_dict()
time) to the max length.add
Preset
routes to APIPlease describe the purpose of this pull request.
Implement the following functions:
- [ ] Update a presetHow to test
Have you tested this PR?
Manual testing: