ra, wfe: use TimestampsForWindow to check renewal #7888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
force-pushed
the
use-timestampsforwindow-to-check-renewal
branch
from
070fdc4 to
2b8b3fc
Compare
|
@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
|
Hi bot, the SQL changes are just a comment. Thanks for noticing! |
jprenken
previously approved these changes
Dec 18, 2024
jprenken
requested review from
a team and
aarongable
and removed request for
a team
aarongable
reviewed
Dec 18, 2024
There was a problem hiding this comment.
LGTM, but this will need to be rebased and re-reviewed after #7887 lands (which currently needs a merge conflict resolved).
jsha
force-pushed
the
add-limit-to-timestampsforwindow
branch
from
08b1b34 to
50c1372
Compare
This allows us to log the time since last issuance (in the RA). It also allows us to delete FQDNSetExists once this is deployed.
jsha
force-pushed
the
use-timestampsforwindow-to-check-renewal
branch
from
48a39d2 to
0d54973
Compare
jprenken
approved these changes
Dec 20, 2024
Merged
aarongable
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And in the RA, log the notBefore of the previous issuance.
To make this happen, I had to hoist the "check for previous certificate" up a level into
issueCertificateOuter. That meant I also had to hoist the "split off a WithoutCancel context" logic all the way up toFinalizeOrder.