Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated otelgrpc interceptors with stats handler #7235

Closed
pgporada opened this issue Jan 2, 2024 · 0 comments · Fixed by #7496
Closed

Replace deprecated otelgrpc interceptors with stats handler #7235

pgporada opened this issue Jan 2, 2024 · 0 comments · Fixed by #7496
Assignees
@pgporada
Milestone
Sprint 2024-01-02

Comments

@pgporada
Copy link
Member

pgporada commented Jan 2, 2024

Recent otelgrpc changes deprecate interceptors that we use throughout the //grpc package.

  • UnaryClientInterceptor
  • StreamClientInterceptor
  • UnaryServerInterceptor
  • StreamServerInterceptor
  • WithInterceptorFilter

Per documentation we should move away from these interceptors in favor of NewClientHandler and NewServerHandler.
@aarongable aarongable added this to the Sprint 2024-01-02 milestone Jan 2, 2024
@pgporada pgporada mentioned this issue Jan 3, 2024
Closed
@aarongable aarongable mentioned this issue May 23, 2024
Merged
aarongable pushed a commit that referenced this issue May 29, 2024
@dependabot
update otel dependencies to v1.27.0 and v0.52.0 (#7496)
6b4577e 
Directly update:
- go.opentelemetry.io/otel/* from v1.26.0 to v1.27.0
- go.opentelemetry.io/contrib/* from v0.51.0 to v0.52.0

Indirectly update:
- google.golang.org/protobuf from v1.33.0 to v1.34.0

This update breaks some of our existing otel grpc interceptors, but in
return allows us to use the newer grpc StatsHandler mechanism, while
still filtering out health-check requests.

Fixes #7235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgporada pgporada

Labels
None yet
Projects
None yet
Milestone
Sprint 2024-01-02
2 participants
@pgporada @aarongable