Skip to content

Commit

Permalink
work around eggsampler bug with todo
Browse files Browse the repository at this point in the history
  • Loading branch information
aarongable committed Dec 18, 2024
1 parent 759107f commit dec50e5
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 10 deletions.
7 changes: 4 additions & 3 deletions test/integration/account_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ func TestAccountDeactivate(t *testing.T) {
t.Errorf("account deactivation should have set status to %q, instead got %q", core.StatusDeactivated, got.Status)
}

if len(got.Contact) != 0 {
t.Errorf("account deactivation should have cleared contacts field, instead got %+v", got.Contact)
}
// TODO(#5554): Check that the contacts have been cleared. We can't do this
// today because eggsampler/acme unmarshals the WFE's response into the same
// account object as it used to make the request, and a wholly missing
// contacts field doesn't overwrite whatever eggsampler was holding in memory.
}
2 changes: 2 additions & 0 deletions vendor/github.com/eggsampler/acme/v3/account.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 6 additions & 7 deletions vendor/github.com/eggsampler/acme/v3/acme.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit dec50e5

Please sign in to comment.