Skip to content

Commit

Permalink
Remove crlURL from test CA issuer configs (#7132)
Browse files Browse the repository at this point in the history
This value is always set to the empty string in prod, which (correctly)
results in the issued certificates not having a CRLDP at all. It turns
out our integration test environment has been including CRLDPs in all of
our test certs because we set crlURL to a non-empty value! This change
updates our test configs to match reality.

I'll remove the code which supports this config value as part of my
upcoming CA CRLDP changes.
  • Loading branch information
aarongable authored Nov 2, 2023
1 parent f24ec91 commit 81cb970
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 8 deletions.
2 changes: 0 additions & 2 deletions test/config-next/ca-a.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
"useForECDSALeaves": true,
"issuerURL": "http://127.0.0.1:4001/aia/issuer/6605440498369741",
"ocspURL": "http://127.0.0.1:4002/",
"crlURL": "http://example.com/crl",
"location": {
"configFile": "/hierarchy/intermediate-signing-key-rsa.pkcs11.json",
"certFile": "/hierarchy/intermediate-cert-rsa-a.pem",
Expand All @@ -86,7 +85,6 @@
"useForECDSALeaves": false,
"issuerURL": "http://127.0.0.1:4001/aia/issuer/41127673797486028",
"ocspURL": "http://127.0.0.1:4002/",
"crlURL": "http://example.com/crl",
"location": {
"configFile": "/hierarchy/intermediate-signing-key-rsa.pkcs11.json",
"certFile": "/hierarchy/intermediate-cert-rsa-b.pem",
Expand Down
2 changes: 0 additions & 2 deletions test/config-next/ca-b.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
"useForECDSALeaves": true,
"issuerURL": "http://127.0.0.1:4001/aia/issuer/6605440498369741",
"ocspURL": "http://127.0.0.1:4002/",
"crlURL": "http://example.com/crl",
"location": {
"configFile": "/hierarchy/intermediate-signing-key-rsa.pkcs11.json",
"certFile": "/hierarchy/intermediate-cert-rsa-a.pem",
Expand All @@ -86,7 +85,6 @@
"useForECDSALeaves": false,
"issuerURL": "http://127.0.0.1:4001/aia/issuer/41127673797486028",
"ocspURL": "http://127.0.0.1:4002/",
"crlURL": "http://example.com/crl",
"location": {
"configFile": "/hierarchy/intermediate-signing-key-rsa.pkcs11.json",
"certFile": "/hierarchy/intermediate-cert-rsa-b.pem",
Expand Down
2 changes: 0 additions & 2 deletions test/config/ca-a.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
"useForECDSALeaves": true,
"issuerURL": "http://127.0.0.1:4001/aia/issuer/6605440498369741",
"ocspURL": "http://127.0.0.1:4002/",
"crlURL": "http://example.com/crl",
"location": {
"configFile": "test/test-ca.key-pkcs11.json",
"certFile": "/hierarchy/intermediate-cert-rsa-a.pem",
Expand All @@ -81,7 +80,6 @@
"useForECDSALeaves": false,
"issuerURL": "http://127.0.0.1:4001/aia/issuer/41127673797486028",
"ocspURL": "http://127.0.0.1:4002/",
"crlURL": "http://example.com/crl",
"location": {
"configFile": "test/test-ca.key-pkcs11.json",
"certFile": "/hierarchy/intermediate-cert-rsa-b.pem",
Expand Down
2 changes: 0 additions & 2 deletions test/config/ca-b.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
"useForECDSALeaves": true,
"issuerURL": "http://127.0.0.1:4001/aia/issuer/6605440498369741",
"ocspURL": "http://127.0.0.1:4002/",
"crlURL": "http://example.com/crl",
"location": {
"configFile": "test/test-ca.key-pkcs11.json",
"certFile": "/hierarchy/intermediate-cert-rsa-a.pem",
Expand All @@ -81,7 +80,6 @@
"useForECDSALeaves": false,
"issuerURL": "http://127.0.0.1:4001/aia/issuer/41127673797486028",
"ocspURL": "http://127.0.0.1:4002/",
"crlURL": "http://example.com/crl",
"location": {
"configFile": "test/test-ca.key-pkcs11.json",
"certFile": "/hierarchy/intermediate-cert-rsa-b.pem",
Expand Down

0 comments on commit 81cb970

Please sign in to comment.