Skip to content

Commit

Permalink
Only run issue-for-sre-handoff when review requested (#7634)
Browse files Browse the repository at this point in the history
Running this workflow on both `ready_for_review` and `review_requested`
was causing duplicate comments to show up when PRs were moved out of
draft mode. This is because moving out of draft mode would both trigger
a workflow run and automatically request review, which in turn would
trigger a second workflow run, and the two runs were triggered in such
quick succession that our commentMarker detection wouldn't work.
  • Loading branch information
aarongable authored Jul 26, 2024
1 parent cf8e5aa commit 17f1ee7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/issue-for-sre-handoff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Check PR for configuration and SQL changes

on:
pull_request:
types: [ready_for_review, review_requested]
types: [review_requested]
paths:
- 'test/config-next/*.json'
- 'test/config-next/*.yaml'
Expand Down

0 comments on commit 17f1ee7

Please sign in to comment.