Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request : possibility to add a custom port to the syslog IP #1258

Closed
Zixim opened this issue Apr 16, 2018 · 10 comments · Fixed by #3148
Closed

feature request : possibility to add a custom port to the syslog IP #1258

Zixim opened this issue Apr 16, 2018 · 10 comments · Fixed by #3148
Labels
Category: Settings Related to settings/configuration Type: Feature Request Add a completely new feature (e.g. controller/plugin)

Comments

@Zixim
Copy link

Zixim commented Apr 16, 2018

My syslog server is listening on port 5140 , there's no way to specify a syslog port in ESPEasy.

Build | 20100 - Mega32
GIT version | (custom)
Plugins | 40 [Normal]
Build Md5 | 4d44355f4d44355f4d44355f4d44355f
Md5 check | fail !
Build time | Mar 30 2018 16:13:45
Binary filename | ThisIsTheDummyPlaceHolderForTheBinaryFilename...

@TD-er TD-er added Type: Feature Request Add a completely new feature (e.g. controller/plugin) Category: Settings Related to settings/configuration labels Apr 16, 2018
@TD-er
Copy link
Member

TD-er commented Apr 16, 2018

Adding a portnumber to the settings is a little bit tricky.
It isn't that hard, but let me think about it for now.
I was planning to change the log entirely, but maybe the re-design of that should wait until after the next release and then it should not be a problem to add the port now.

@cybermaus
Copy link

I would like to make the same request / bump this request up: Please allow for custom port for syslog.

I use cloud service "Papertrail" for syslog services, for years already, and they assign each of their customers a set of ports so they can distinguish between their customers.

Small extra request: be allowed to use hostname as well as IP for the syslog IP

Build:⋄ 20103 - Mega
System Libraries:⋄ ESP82xx Core 2_5_2, NONOS SDK 2.2.1(cfd48f3), LWIP: 2.1.2 PUYA support
Git Build:⋄ mega-20190813
Plugins:⋄ 48 [Normal]
Build Md5: 74939a896fe719b99f217da49cfa12
Md5 check: passed.
Build Time:⋄ Aug 13 2019 02:13:44
Binary Filename:⋄ ESP_Easy_mega-20190813_normal_ESP8285_1M.bin

@uzi18
Copy link
Contributor

uzi18 commented Aug 16, 2019

@TD-er it is simply possible by extending host address like host:port, then check in software if it contains ':'
where host could be also IP

@TD-er
Copy link
Member

TD-er commented Aug 16, 2019

If it is already a string and not an IP being stored, then sure it is a very simple fix.
But since @cybermaus did ask for a hostname, I don't think it is that easy.
Also check for max length of host being stored?

@cybermaus
Copy link

cybermaus commented Aug 16, 2019

While I understand you meant it as hint/proof the field is not a string, but please note the hostname request is just a nicety. The port is the real request.

Also FYI: I did try the host:port and IP:port syntax already. But upon refresh the field comes back blank. Indeed only an IP address is accepted as value.

@IoTPlay
Copy link

IoTPlay commented Apr 7, 2020

@TD-er - another vote from me. Ip address:port no for udp syslog.

Please..... pretty please?

@mozgovs
Copy link

mozgovs commented Jun 29, 2020

One more vote from me.
IP:PORT will be enough;)

@dl2suf
Copy link

dl2suf commented Jul 10, 2020

and another vote from me.

TD-er added a commit to TD-er/ESPEasy that referenced this issue Jul 19, 2020
@TD-er
Copy link
Member

TD-er commented Jul 19, 2020

It has been implemented and will be merged soon.

@IoTPlay
Copy link

IoTPlay commented Jul 20, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Settings Related to settings/configuration Type: Feature Request Add a completely new feature (e.g. controller/plugin)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants