fix: operation==replace assertion fixed #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
operation["op"].casecmp("replace")
will allways return a "truthy" value, so it is useless for checking if the operation param is actually "replace". Thecasecpm?
method should be used.What?
Just changes
operation["op"].casecmp("replace")
foroperation["op"].casecmp?("replace")
.Caveats
None
Testing Notes
I don't think any specific testing is required.