Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: operation==replace assertion fixed #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lothardp
Copy link

@lothardp lothardp commented Jan 2, 2024

Why?

operation["op"].casecmp("replace") will allways return a "truthy" value, so it is useless for checking if the operation param is actually "replace". The casecpm? method should be used.

What?

Just changes operation["op"].casecmp("replace") for operation["op"].casecmp?("replace").

Caveats

None

Testing Notes

I don't think any specific testing is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant