Extract user retrieval into its own method for easy overriding #62
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -1,5 +1,5 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module ScimRails | |||
| VERSION = "0.4.0" | |||
| VERSION = "0.4.1" | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -1,7 +1,7 @@ | |||
| # Be sure to restart your server when you modify this file. | |||
|
|
|||
| # Version of your assets, change this if you want to expire all your assets. | |||
| Rails.application.config.assets.version = '1.0' | |||
| #Rails.application.config.assets.version = '1.0' | |||
There was a problem hiding this comment.
Layout/LeadingCommentSpace: Missing space after #.
Add compatibility with Ruby 3.1
| t.datetime "created_at", null: false | ||
| t.datetime "updated_at", null: false | ||
| t.datetime "created_at", null: false | ||
| t.datetime "updated_at", null: false |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| t.datetime "archived_at" | ||
| t.datetime "created_at", null: false | ||
| t.datetime "updated_at", null: false | ||
| t.datetime "created_at", null: false |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| t.string "first_name", null: false | ||
| t.string "last_name", null: false | ||
| t.string "email", null: false | ||
| t.integer "company_id" |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| t.integer "company_id" | ||
| t.string "first_name", null: false | ||
| t.string "last_name", null: false | ||
| t.string "email", null: false |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| t.string "email", null: false | ||
| t.integer "company_id" | ||
| t.string "first_name", null: false | ||
| t.string "last_name", null: false |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| t.string "subdomain", null: false | ||
| t.string "api_token", null: false | ||
| t.string "name", null: false | ||
| t.string "subdomain", null: false |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| t.string "name", null: false | ||
| t.string "subdomain", null: false | ||
| t.string "api_token", null: false | ||
| t.string "name", null: false |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| # | ||
| # It's strongly recommended that you check this file into your version control system. | ||
|
|
||
| ActiveRecord::Schema.define(version: 20181206184313) do | ||
| ActiveRecord::Schema.define(version: 2018_12_06_184313) do |
There was a problem hiding this comment.
Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3 digits with them.
| # from scratch. The latter is a flawed and unsustainable approach (the more migrations | ||
| # you'll amass, the slower it'll run and the greater likelihood for issues). | ||
| # This file is the source Rails uses to define your schema when running `bin/rails | ||
| # db:schema:load`. When creating a new database, `bin/rails db:schema:load` tends to |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [84/80]
| # system, you should be using db:schema:load, not running all the migrations | ||
| # from scratch. The latter is a flawed and unsustainable approach (the more migrations | ||
| # you'll amass, the slower it'll run and the greater likelihood for issues). | ||
| # This file is the source Rails uses to define your schema when running `bin/rails |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [82/80]
allow for Rails 7
allow for Rails 7
| @@ -10,5 +10,5 @@ gemspec | |||
| # Git. Remember to move these dependencies to your gemspec before releasing | |||
| # your gem to rubygems.org. | |||
|
|
|||
| gem "rails", "~> 6.1", ">= 6.0" | |||
| gem "rails", ">= 6.1" | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Change condition to < 7.2
Pretty self explanatory I think.