Upgrade Rspec to ~5.0; support Rails 6.1 #41
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -10,5 +10,5 @@ gemspec | |||
| # Git. Remember to move these dependencies to your gemspec before releasing | |||
| # your gem to rubygems.org. | |||
|
|
|||
| gem "rails", "~> 6.0" | |||
| gem "rails", "~> 6.1", ">= 6.0" | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
There was a problem hiding this comment.
Bad boy hound 😆 🐕 I must need to adjust the settings because it should be looking for double quotes; so this is just fine.
|
Hi @henrypoydar !!! Thanks so much for this PR; really appreciate it 🙌🏻 . I'll check it out and work on get back with ya if there is any feedback. Looks pretty straightforward 🎉 |
There was a problem hiding this comment.
This all looks great to me!! The build for Rails 5 and Ruby 2.6 are both still green in Travis as well as the builds for Rails 6 and Ruby 2.7.
Really appreciate your help @henrypoydar !
| @@ -10,5 +10,5 @@ gemspec | |||
| # Git. Remember to move these dependencies to your gemspec before releasing | |||
| # your gem to rubygems.org. | |||
|
|
|||
| gem "rails", "~> 6.0" | |||
| gem "rails", "~> 6.1", ">= 6.0" | |||
There was a problem hiding this comment.
Bad boy hound 😆 🐕 I must need to adjust the settings because it should be looking for double quotes; so this is just fine.
Why?
To use this gem with a Rails 6.1 application
What?
Bumps development environment to Ruby 2.7.2. from Ruby 2.6.2
Upgrades rspec-rails from 3.0 to 5.0
Bumps upper limit on Rails support from 6.0 to 6.1
Testing Notes
All specs pass, but did not test with earlier Rails < 6.0. Recommend a minor release instead of a patch release, and bumping up the minimum Rails version to 6.0.